October 2019 - flashrom-gerrit

Change in flashrom[master]: util/git-hooks: Check for Signed-off-by line
by David Hendricks (Code Review) 14 Oct '19

14 Oct '19

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35295 ) Change subject: util/git-hooks: Check for Signed-off-by line ...................................................................... util/git-hooks: Check for Signed-off-by line Enforce the DCO. The logic comes from coreboot's commit-msg hook, and I've added a pointer to flashrom's development guidelines. Change-Id: Iea49a06c2d4824be073eff98c8aae1cbc5b145e4 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M util/git-hooks/commit-msg 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/35295/1 diff --git a/util/git-hooks/commit-msg b/util/git-hooks/commit-msg index 346c08f..fff0e29 100755 --- a/util/git-hooks/commit-msg +++ b/util/git-hooks/commit-msg @@ -28,6 +28,8 @@ CHANGE_ID_AFTER="Bug|Depends-On|Issue|Test|Feature|Fixes|Fixed|Staging-ID" MSG="$1" +DEV_GUIDELINES_URL="https://www.flashrom.org/Development_Guidelines" + # Check for, and add if missing, a unique Change-Id # add_ChangeId() { @@ -201,8 +203,17 @@ } } +test_sign_off() { + if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then + printf "\nError: No Signed-off-by line in the commit message.\n" + printf "See: ${DEV_GUIDELINES_URL}\n" + exit 1 + fi +} + main() { test_duplicate_signoffs_acks + test_sign_off add_ChangeId } -- To view, visit https://review.coreboot.org/c/flashrom/+/35295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea49a06c2d4824be073eff98c8aae1cbc5b145e4 Gerrit-Change-Number: 35295 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: newchange

2 5

Change in flashrom[master]: [HACK]flashchips: Use spi_chip_write_256 on SST25VF016B
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/30088 ) Change subject: [HACK]flashchips: Use spi_chip_write_256 on SST25VF016B ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/30088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8000f538a55c10dd55aedd4265c036590f3b96a8 Gerrit-Change-Number: 30088 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/27106 ) Change subject: [WIP]layout.c: Use a linked lists for layout ...................................................................... Abandoned Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/27106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Gerrit-Change-Number: 27106 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Abandoned Might resume this later, but abandoning for now. -- To view, visit https://review.coreboot.org/c/flashrom/+/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: Fix compilation if CONFIG_INTERNAL=no
by Jonathan Liu (Code Review) 08 Oct '19

08 Oct '19

Jonathan Liu has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35808 ) Change subject: Fix compilation if CONFIG_INTERNAL=no ...................................................................... Fix compilation if CONFIG_INTERNAL=no Change-Id: Id9e07332003832465a0eccf1d89e73d15abb35c0 Signed-off-by: Jonathan Liu <net147(a)gmail.com> --- M libflashrom.c M physmap.c 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/35808/1 diff --git a/libflashrom.c b/libflashrom.c index dbc5129..f3e69ff 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -171,18 +171,21 @@ struct flashrom_board_info *flashrom_supported_boards(void) { int boards_known_size = 0; +#if CONFIG_INTERNAL == 1 int i = 0; const struct board_info *binfo = boards_known; while ((binfo++)->vendor) ++boards_known_size; binfo = boards_known; +#endif /* add place for {0} */ ++boards_known_size; struct flashrom_board_info *supported_boards = - malloc(boards_known_size * sizeof(*binfo)); + malloc(boards_known_size * sizeof(*supported_boards)); +#if CONFIG_INTERNAL == 1 if (supported_boards != NULL) { for (; i < boards_known_size; ++i) { supported_boards[i].vendor = binfo[i].vendor; @@ -192,6 +195,7 @@ } else { msg_gerr("Memory allocation error!\n"); } +#endif return supported_boards; } @@ -203,18 +207,21 @@ struct flashrom_chipset_info *flashrom_supported_chipsets(void) { int chipset_enables_size = 0; +#if CONFIG_INTERNAL == 1 int i = 0; const struct penable *chipset = chipset_enables; while ((chipset++)->vendor_name) ++chipset_enables_size; chipset = chipset_enables; +#endif /* add place for {0}*/ ++chipset_enables_size; struct flashrom_chipset_info *supported_chipsets = malloc(chipset_enables_size * sizeof(*supported_chipsets)); +#if CONFIG_INTERNAL == 1 if (supported_chipsets != NULL) { for (; i < chipset_enables_size; ++i) { supported_chipsets[i].vendor = chipset[i].vendor_name; @@ -226,6 +233,7 @@ } else { msg_gerr("Memory allocation error!\n"); } +#endif return supported_chipsets; } diff --git a/physmap.c b/physmap.c index ad38ad3..c6a2076 100644 --- a/physmap.c +++ b/physmap.c @@ -430,6 +430,7 @@ return 0; } +#if CONFIG_INTERNAL == 1 int setup_cpu_msr(int cpu) { char msrfilename[64]; @@ -464,6 +465,8 @@ /* Clear MSR file descriptor. */ fd_msr = -1; } +#endif + #elif defined(__OpenBSD__) && defined (__i386__) /* This does only work for certain AMD Geode LX systems see amdmsr(4). */ #include <sys/ioctl.h> #include <machine/amdmsr.h> -- To view, visit https://review.coreboot.org/c/flashrom/+/35808 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id9e07332003832465a0eccf1d89e73d15abb35c0 Gerrit-Change-Number: 35808 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Liu <net147(a)gmail.com> Gerrit-MessageType: newchange

3 10

Change in flashrom[master]: chipset_enable.c: Mark Intel Q75 as DEP
by Angel Pons (Code Review) 08 Oct '19

08 Oct '19

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35826 ) Change subject: chipset_enable.c: Mark Intel Q75 as DEP ...................................................................... chipset_enable.c: Mark Intel Q75 as DEP Tested reading, writing and erasing the internal flash chip using an HP Pro 6300 SFF mainboard with an Intel Q75 PCH. However, since ME-enabled chipsets are marked as DEP instead of OK, this one shall also be. Change-Id: I273af0eb33e74b31bc4fdc95362527bba080c5a0 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/35826/1 diff --git a/chipset_enable.c b/chipset_enable.c index f02ba87..b55852c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1823,7 +1823,7 @@ {0x8086, 0x1e44, B_FS, DEP, "Intel", "Z77", enable_flash_pch7}, {0x8086, 0x1e46, B_FS, NT, "Intel", "Z75", enable_flash_pch7}, {0x8086, 0x1e47, B_FS, NT, "Intel", "Q77", enable_flash_pch7}, - {0x8086, 0x1e48, B_FS, NT, "Intel", "Q75", enable_flash_pch7}, + {0x8086, 0x1e48, B_FS, DEP, "Intel", "Q75", enable_flash_pch7}, {0x8086, 0x1e49, B_FS, DEP, "Intel", "B75", enable_flash_pch7}, {0x8086, 0x1e4a, B_FS, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, B_FS, NT, "Intel", "C216", enable_flash_pch7}, -- To view, visit https://review.coreboot.org/c/flashrom/+/35826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I273af0eb33e74b31bc4fdc95362527bba080c5a0 Gerrit-Change-Number: 35826 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

2 2

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Nico Huber (Code Review) 08 Oct '19

08 Oct '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 26: Code-Review+1 (2 comments) Looks good, thanks for the update. Alas, I seem to have found an issue that I missed earlier. https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c File ni845x_spi.c: https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c@249 PS26, Line 249: i >= 0 Did you test this with unexpected inputs, e.g. command line argument of 1.0V? Didn't see this earlier, but it looks like we'd end up with `i = -1`. But the code after this loops assumes that we stop at 0 (i.e. `i` is always a valid array index). So the last iteration should be for `i == 1`, i.e. the condition should be `i > 0`. https://review.coreboot.org/c/flashrom/+/25683/26/ni845x_spi.c@440 PS26, Line 440: strlen(ignore_io_voltage_limits_str) == 3 : && strstr("yes", ignore_io_voltage_limits_str) == 0 This should be the same as strcmp(ignore_io_voltage_limits_str, "yes") == 0 no? -- To view, visit https://review.coreboot.org/c/flashrom/+/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 26 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Stefan T <stefan.tauner(a)gmx.at> Gerrit-Comment-Date: Tue, 08 Oct 2019 09:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/30411 ) Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Makefile,meson.build: Enable/assume -Wextra Enable all -Wextra warnings but -Wunused-parameter. Nobody seems to miss warnings about unused parameters and we have a lot unavoidable occurrences in flashrom because of common interfaces. Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/30411 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jacob Garber <jgarber1(a)ualberta.ca> --- M Makefile M meson.build 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Jacob Garber: Looks good to me, approved diff --git a/Makefile b/Makefile index b0c242d..f0a1b61 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ DIFF = diff PREFIX ?= /usr/local MANDIR ?= $(PREFIX)/share/man -CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes -Wwrite-strings +CFLAGS ?= -Os -Wall -Wextra -Wno-unused-parameter -Wshadow -Wmissing-prototypes -Wwrite-strings EXPORTDIR ?= . RANLIB ?= ranlib PKG_CONFIG ?= pkg-config diff --git a/meson.build b/meson.build index fda1ab8..ca52ccf 100644 --- a/meson.build +++ b/meson.build @@ -15,10 +15,8 @@ warning_flags = [ '-Wwrite-strings', '-Wno-unused-parameter', - '-Wno-sign-compare', '-Wno-address-of-packed-member', '-Wno-enum-conversion', - '-Wno-missing-field-initializers', '-Wno-missing-braces', ] -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Limonciello <superm1(a)gmail.com> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashchips: Add missing block erasers for GD25Q256D
by Nico Huber (Code Review) 06 Oct '19

06 Oct '19

Hello Edward O'Callaghan, Alan Green, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/35798 to review the following change. Change subject: flashchips: Add missing block erasers for GD25Q256D ...................................................................... flashchips: Add missing block erasers for GD25Q256D Change-Id: I7e49e468c7f1eaf0ddd5fc08d6cc6569274faf94 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/35798/1 diff --git a/flashchips.c b/flashchips.c index 7635942..f542445 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6290,12 +6290,21 @@ { { .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, .block_erase = spi_block_erase_20, }, { .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 1024} }, .block_erase = spi_block_erase_52, }, { .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 512} }, .block_erase = spi_block_erase_d8, }, { .eraseblocks = { {32 * 1024 * 1024, 1} }, -- To view, visit https://review.coreboot.org/c/flashrom/+/35798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7e49e468c7f1eaf0ddd5fc08d6cc6569274faf94 Gerrit-Change-Number: 35798 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

2 2

Change in flashrom[master]: Makefile,meson.build: Enable/assume -Wextra
by Jacob Garber (Code Review) 06 Oct '19

06 Oct '19

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30411 ) Change subject: Makefile,meson.build: Enable/assume -Wextra ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/30411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ece264c2d483e34019985dd3a7631c4889abe6 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 9 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Limonciello <superm1(a)gmail.com> Gerrit-Comment-Date: Sat, 05 Oct 2019 23:33:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2019