Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38844 )
Change subject: mainboard/hatch/mainboard.c: Accommodate larger SKU id space
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38844/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38844/2/src/mainboard/google/hatch/...
PS2, Line 25: 0x7FFFFFFF
Is this true for all of hatch or just Puff? +Shelley and +Tim.
They're definitely only 8 bits in all of the hatch variants.
The highest I know of is 24.
We also use 255 for un-provisioned devices.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5a3f47989f596b838739becfb1da1bdaf16dd27
Gerrit-Change-Number: 38844
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 20:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment