Attention is currently required from: Kapil Porwal, Paul Menzel, Paz Zcharya, Shelley Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80738?usp=email )
Change subject: vc/google/chromeos: Implement dynamic ChromeOS boot logo selection ......................................................................
Patch Set 5:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80738/comment/61ef05ae_046e4d8d : PS5, Line 7: Enable
“Enable” for me is ambiguous. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/64da706b_0e9cc313 : PS5, Line 8:
Can you please summarize the problem that is addressed with the new feature?
Acknowledged
File src/vendorcode/google/chromeos/tpm_factory_config.c:
https://review.coreboot.org/c/coreboot/+/80738/comment/546d04ab_a557223d : PS5, Line 51: needs
need
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/5b61c3f9_4309df1c : PS5, Line 60: return ((factory_config & CHROMEBOOK_PLUS_DEVICE) == CHROMEBOOK_PLUS_DEVICE) ? true : false;
Isn’t this equal to […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/a62a711e_db255a9c : PS5, Line 70: that
that is?
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/d70df2f2_4d7dfae3 : PS5, Line 89: Chromebook-Plus
This is spelled inconsistently in the file – without and with hyphen.
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/e072d995_0cd1148b : PS5, Line 92: needs
need
Acknowledged
https://review.coreboot.org/c/coreboot/+/80738/comment/9236bce5_fbd42fc6 : PS5, Line 105: if (strncmp((char *)device_info, "CAI", 3) == 0) : return true; : else : return false;
Should be equivalent to […]
Acknowledged