[M] Change in coreboot[master]: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG

[Subrata Banik (Code Review)]

Attention is currently required from: Bernardo Perez Priego, Jamie Ryu, Jay Patel, Kapil Porwal, Li1 Feng, Tarun Tuli, Wonkyu Kim.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )

Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................

Patch Set 8:

(5 comments)

Patchset:

PS8: 
I would request the reviewer to review the code wisely rather casting the CR+2 as is.

File src/mainboard/google/rex/variants/rex0/fw_config.c:

https://review.coreboot.org/c/coreboot/+/75525/comment/aae612fb_02a08586 :
PS8, Line 104: 1
what does `1` refer to here?

https://review.coreboot.org/c/coreboot/+/75525/comment/01729542_b649b0b7 :
PS8, Line 104:  {
why brace for single line statement ?

https://review.coreboot.org/c/coreboot/+/75525/comment/29cf5951_227ebacd :
PS8, Line 107: 2
what does `2` refer to here?

https://review.coreboot.org/c/coreboot/+/75525/comment/7b9d5704_65fc8f03 :
PS8, Line 111: printk(BIOS_ERR, "Unknown Board Version for ISH.\n");
What happens when there is board version is unknown?

die ?