Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62774 )
Change subject: soc/intel/common/block/p2sb: Refactor P2SB to add comprehend future SoC ......................................................................
soc/intel/common/block/p2sb: Refactor P2SB to add comprehend future SoC
This patch refactors the current P2SB common code driver to accommodate the future SoC platform with provision of more than one P2SB IP in disaggregated die architecture.
IA SoC has only one P2SB in PCH die between SKL to ADL. Starting with MTL, one more P2SB IP resides in IOE die along with SoC die (PCH die is renamed as SoC in MTL).
P2SB library (p2sblib.c) is common between PCH/SoC and IOE, and p2sb.c is added only for PCH/SoC P2SB.
BUG=b:224325352 TEST=Able to build and boot brya.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ib671d9acbfdc61305ebb401499bfc4742b738ffb --- M src/soc/intel/common/block/p2sb/Kconfig M src/soc/intel/common/block/p2sb/Makefile.inc 2 files changed, 16 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/62774/1
diff --git a/src/soc/intel/common/block/p2sb/Kconfig b/src/soc/intel/common/block/p2sb/Kconfig index 7f292cd..ff20255 100644 --- a/src/soc/intel/common/block/p2sb/Kconfig +++ b/src/soc/intel/common/block/p2sb/Kconfig @@ -1,5 +1,11 @@ -config SOC_INTEL_COMMON_BLOCK_P2SB +config SOC_INTEL_COMMON_BLOCK_BASE_P2SB bool depends on SOC_INTEL_COMMON_BLOCK_PCR help - Intel Processor common P2SB driver + Intel Processor common P2SB base driver + +config SOC_INTEL_COMMON_BLOCK_P2SB + bool + select SOC_INTEL_COMMON_BLOCK_BASE_P2SB + help + Intel Processor common P2SB driver for PCH or SoC die diff --git a/src/soc/intel/common/block/p2sb/Makefile.inc b/src/soc/intel/common/block/p2sb/Makefile.inc index 5c6378e..f8e488c 100644 --- a/src/soc/intel/common/block/p2sb/Makefile.inc +++ b/src/soc/intel/common/block/p2sb/Makefile.inc @@ -1,8 +1,8 @@ -ifeq ($(CONFIG_SOC_INTEL_COMMON_BLOCK_P2SB),y) -bootblock-y += p2sb.c -romstage-y += p2sb.c -ramstage-y += p2sb.c -ramstage-y += p2sblib.c -smm-y += p2sb.c -smm-y += p2sblib.c -endif +ramstage-$(SOC_INTEL_COMMON_BLOCK_BASE_P2SB) += p2sblib.c +smm-$(SOC_INTEL_COMMON_BLOCK_BASE_P2SB) += p2sblib.c + +# p2sb.c for PCH and SoC die P2SB IP +bootblock-$(CONFIG_SOC_INTEL_COMMON_BLOCK_P2SB) += p2sb.c +romstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_P2SB) += p2sb.c +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_P2SB) += p2sb.c +smm-$(CONFIG_SOC_INTEL_COMMON_BLOCK_P2SB) += p2sb.c