Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21692 )
Change subject: mainboard/google/soraka: Reduce Wacom resume time ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/21692/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/21692/1//COMMIT_MSG@21 PS1, Line 21: manual testing on Soraka board to ensue that touchscreen works at boot : and after suspend/resume. I think this change should be fine, but I have a few questions: 1. Did you timestamp the two points -- touchscreen device being taken out of reset and the first communication from the driver to the device? Can you please do it over multiple iterations to ensure that the delay is > 100ms? 2. If #1 is true, why even add a delay of 10ms? 3. What happens if suspend fails and system resumes mid-way i.e. suppose touchscreen device is suspended and then system starts resuming without completing the suspend? Can this lead to a race condition?