Attention is currently required from: Derek Huang, Henry Sun, Tarun Tuli, Yunlong Jia.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76013?usp=email )
Change subject: mb/google/nissa/var/gothrax: Initialise overridetree
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brya/variants/gothrax/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76013/comment/0b21e54f_1d99752e :
PS4, Line 332: register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WFC
trailing whitespace
Please fix. This will fix the CI error.
https://review.coreboot.org/c/coreboot/+/76013/comment/1f1a5c4a_46b028d0 :
PS4, Line 335: register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/3 Type A port A1
add an empty line here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76013?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfd9788a75f9c342f85d6e1a3d54327d64797dd8
Gerrit-Change-Number: 76013
Gerrit-PatchSet: 4
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Jun 2023 07:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment