Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50143 )
Change subject: nb/intel/haswell: Program Mini-HD EM4 and EM5 registers ......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/haswell/minihd.c:
https://review.coreboot.org/c/coreboot/+/50143/comment/08f5a692_77b66fc6 PS3, Line 67: /* Mini-HD configuration */ : reg32 = read32(base + 0x100c); : reg32 &= 0xfffc0000; : reg32 |= 0x4; : write32(base + 0x100c, reg32); : : reg32 = read32(base + 0x1010); : reg32 &= 0xfffc0000; : reg32 |= 0x4b; : write32(base + 0x1010, reg32); Looks like this programs the EM4/EM5 registers with fixed values. Given that Broadwell code also has this, I'd prefer to look into removing this once the code is deduplicated.