Attention is currently required from: Tarun Tuli, SRIDHAR SIRICILLA, Subrata Banik, Dinesh Gehlot, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74382 )
Change subject: soc/intel/cmn/cse: Move API to get FW partition info into cse_lite.c
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74382/comment/7a40ad86_d6a27a88
PS1, Line 9: The patch moves API that gets the CSE FW partition information into
: CSE Lite specific file aka cse_lite.c because the consumer of this API
: is the cse_lite specific ChromeOS devices hence, it's meaningful to
: move the cse lite specific implementation inside cse_lite.c file.
cse.c represents library, provides API. I don't see any need to move the GET IMAGE FW INFO command handler into cse_lite.c. I request you to reconsider the option of moving the API into cse_lite.c. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49ffaec467f6fb24327de3b2882e37bf31eeb7cf
Gerrit-Change-Number: 74382
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 07:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment