Change in coreboot[master]: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config - coreboot-gerrit

10 Apr 2022


      Attention is currently required from: Nico Huber, Alexander Couzens.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63530 )
Change subject: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/lenovo/t410/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63530/comment/bb65de59_9978dd25 
PS1, Line 138: 					# -DISCRETE_PRESENCE
What does the - in the beginning denote?
https://review.coreboot.org/c/coreboot/+/63530/comment/c75b5f13_06242180 
PS1, Line 143: 					register "ddc_mux_gpio" = "54"
Can’t `has_ddc_mux_gpio` be derived from having `ddc_mux_gpio` set?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449
Gerrit-Change-Number: 63530
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 10 Apr 2022 11:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment