Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Jeff Daly, Lance Zhao, Matt DeVillier, Paul Menzel, Sean Rhodes, Tim Wawrzynczak, Vanessa Eusebio.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75729?usp=email )
Change subject: acpi: Move ECAM resource below PNP0C02 device in a common place
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75729/comment/0bfd3b25_3b30e4dc :
PS6, Line 27:
Could break the line here to get a perfect block :)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75729/comment/9a4eaaf9_ed7e3cb6 :
PS2, Line 587: struct device *dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
: assert(dev != NULL);
Hmmm, looks like we always set `.ops` for the domain? Technically, it's like […]
I kind of rememeberd that we have a `dsdt_top` now :D but there's
even the right `if` already, amazing!
I've checked with a little bash foo that we always include it, looks
good:
```
$ diff -u <(git grep -l dsdt_top.asl) <(git ls-files */dsdt.asl)
--- /dev/fd/63 2023-06-21 12:08:33.095420956 +0200
+++ /dev/fd/62 2023-06-21 12:08:33.098754243 +0200
@@ -182,4 +182,3 @@
src/mainboard/system76/tgl-u/dsdt.asl
src/mainboard/system76/whl-u/dsdt.asl
src/mainboard/up/squared/dsdt.asl
-util/autoport/main.go
```
https://review.coreboot.org/c/coreboot/+/75729/comment/f0958517_ed793085 :
PS2, Line 594: 1
It should be unique among "PNP0C02" devices. I don't think we need _UID here. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75729?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I852e393726a1b086cf582f4d2d707e7cde05cbf4
Gerrit-Change-Number: 75729
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 21 Jun 2023 10:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment