Attention is currently required from: Eric Lai, Jakub Czapiga, Kane Chen, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )
Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................
Patch Set 25:
(2 comments)
Patchset:
PS23:
- I don’t see any redundant entries. […]
I will send the log.
my question is how to understand from the above entry which one is for SOC.PMC and IOE.PMC?
Tag = 0 for SOC PMC
Tag = 1 for IOE
File src/soc/intel/meteorlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/74769/comment/1cc34e82_dea78b36 :
PS24, Line 63: pcireg = pci_read_config16(sram_dev, PCI_COMMAND);
: pcireg &= ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY);
: pci_write_config16(sram_dev, PCI_COMMAND, pcireg);
can we use `pci_update_config16`?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0abd697fba35edf1c03d2a3a325b7785b985cd5
Gerrit-Change-Number: 74769
Gerrit-PatchSet: 25
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Thu, 22 Jun 2023 02:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment