[M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details

[Dinesh Gehlot (Code Review)]

Attention is currently required from: Haribalaraman Ramasubramanian, Paul Menzel, Rizwan Qureshi, Reka Norman.

Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )

Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................

Patch Set 28:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74005/comment/8e90a996_5bd30181 
PS27, Line 9: FPT
> Firmware Partition T? or is it PT for partition?

Ack

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/74005/comment/9ae7ef69_2143ae6e 
PS27, Line 1242: 		printk(BIOS_ERR, "HECI: Prerequisites not met for fw partition request\n");
> For debugging it might be easier to check each condition separately, and log what condition failed. […]

I agree that is another way to do it. However, I believe that the current clubbed conditions are distinctively identifiable.

https://review.coreboot.org/c/coreboot/+/74005/comment/43fe3fd0_099143ce 
PS27, Line 1250: resp->hdr.result
> Is `resp->hdr. […]

No, `resp->hdr.result` is not always set, it depends on the result of the heci_send_receive() operation. If heci_send_receive() succeeds, it returns zero. If it fails, it returns a non-zero value.

https://review.coreboot.org/c/coreboot/+/74005/comment/5ac41c7a_e36c520d 
PS27, Line 1260: 		printk(BIOS_INFO, "CSE: Info request denied, recovery mode or no CSE LITE SKU\n");
> To help debugging an issue, I’d log a dedicated message for each condition.

Ack