Change in coreboot[master]: cpu/x86/smm_module_loader.c: Rewrite setup more purely function

[Arthur Heymans (Code Review)]

Attention is currently required from: Edward O'Callaghan.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63475 )

Change subject: cpu/x86/smm_module_loader.c: Rewrite setup more purely function
......................................................................

Patch Set 3:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/63475/comment/c3f99a4c_d109507e 
PS3, Line 7: Rewrite setup more purely function
fix...

File src/cpu/x86/smm/smm_module_loader.c:

https://review.coreboot.org/c/coreboot/+/63475/comment/73ab2462_1a14cbc4 
PS3, Line 499: handler_size = rmodule_memory_size(&smm_mod);
             : 	base -= handler_size;
             : 	total_size += handler_size;
             : 	module_alignment = rmodule_load_alignment(&smm_mod);
             : 	alignment_size = module_alignment - (base % module_alignment);
             : 	if (alignment_size != module_alignment) {
             : 		handler_size += alignment_size;
             : 		base += alignment_size;
             : 	}
This is actually totally broken... Also fixed with this.
TODO: Add to the commit message.

https://review.coreboot.org/c/coreboot/+/63475/comment/027a1fb3_829021ad 
PS3, Line 88: const unsigned
push to previous patch.