Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Stefan Reinauer, Subrata Banik, Tyler Wang.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81928?usp=email )
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
Patch Set 7:
(3 comments)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/81928/comment/73acd7e4_177f0181 :
PS4, Line 1802: reg.data.write_protect_en
Refer `enable_gpr0()` to check "Enabled" settings: […]
Thanks!
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/81928/comment/b4fcc519_8194699f :
PS7, Line 1799: reg
nit: maybe rename this to something like `expected` to make it clearer.
https://review.coreboot.org/c/coreboot/+/81928/comment/91b063e3_cf770445 :
PS7, Line 1801:
: uint32_t gpr0_range_start, gpr0_range_end;
:
: if (calculate_gpr0_range(image, size, &gpr0_range_start, &gpr0_range_end))
: exit(EXIT_FAILURE);
:
: reg.data.start = (gpr0_range_start >> 12) & 0x7fff;
: reg.data.end = (gpr0_range_end >> 12) & 0x7fff;
: reg.data.read_protect_en = 0;
: reg.data.write_protect_en = 1;
:
Can you factor this out into a helper function like get_enabled_gprd(), and use it both here and in enable_gpr0() to avoid duplication.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 7
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 01:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment