Attention is currently required from: Forest Mittelberg, Peter Marheine.
Subrata Banik has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/coreboot/+/82775?usp=email )
Change subject: chromeec: supporting reading long battery strings
......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/82775/comment/ca43a8e2_56a1a0d5?usp... :
PS1, Line 63: If supported by the EC,
may be I'm missing the point here, how do we check if reading the long length Battery string command is supported or not ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82775?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia29cacb7d86402490f9ac458f0be50e3f2192b04
Gerrit-Change-Number: 82775
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 04 Jun 2024 07:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No