Change in coreboot[master]: drivers/intel/dptf: Add missing scope operator around TSR options

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: dptf:...

Tim Wawrzynczak (Code Review)

14 Jul 2020 14 Jul '20

7:21 p.m.

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

drivers/intel/dptf: Add missing scope operator around TSR options

The previous DPTF patch train missed the proper scope operator around all of the TSR options. Without this, the optional GTSH and/or _STR Methods end up in the wrong scope.

Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f --- M src/drivers/intel/dptf/dptf.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/43458/1

diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 1e4063e..3d3b63e 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -95,9 +95,12 @@

/* TSR options */ for (p = DPTF_TEMP_SENSOR_0, i = 0; p <= DPTF_TEMP_SENSOR_3; ++p, ++i) { - if (tsr_en[i]) { + if (tsr_en[i] && (config->options.tsr[i].hysteresis || + config->options.tsr[i].desc)) { + dptf_write_scope(p); dptf_write_tsr_hysteresis(config->options.tsr[i].hysteresis); dptf_write_STR(config->options.tsr[i].desc); + acpigen_pop_len(); /* Scope */ } }

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

14 Jul 14 Jul

7:36 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Comment-Date: Tue, 14 Jul 2020 19:36:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

8:11 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Jul 2020 20:11:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sumeet R Pawnikar (Code Review)

15 Jul 15 Jul

4:56 a.m.

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 Jul 2020 04:56:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

16 Jul 16 Jul

9:08 p.m.

Hello build bot (Jenkins), Duncan Laurie, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43458

to look at the new patch set (#2).

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

drivers/intel/dptf: Add missing scope operator around TSR options

The previous DPTF patch train missed the proper scope operator around all of the TSR options. Without this, the optional GTSH and/or _STR Methods end up in the wrong scope.

Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f --- M src/drivers/intel/dptf/dptf.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/43458/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

17 Jul 17 Jul

11:23 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 17 Jul 2020 23:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

18 Jul 18 Jul

4:04 p.m.

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43458 )

Change subject: drivers/intel/dptf: Add missing scope operator around TSR options ......................................................................

drivers/intel/dptf: Add missing scope operator around TSR options

The previous DPTF patch train missed the proper scope operator around all of the TSR options. Without this, the optional GTSH and/or _STR Methods end up in the wrong scope.

Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Reviewed-on: https://review.coreboot.org/c/coreboot/+/43458 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/dptf/dptf.c 1 file changed, 4 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 4bc6b08..a13f6d0 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -215,9 +215,12 @@

/* TSR options */ for (p = DPTF_TEMP_SENSOR_0, i = 0; p <= DPTF_TEMP_SENSOR_3; ++p, ++i) { - if (is_participant_used(config, p)) { + if (is_participant_used(config, p) && (config->options.tsr[i].hysteresis || + config->options.tsr[i].desc)) { + dptf_write_scope(p); dptf_write_tsr_hysteresis(config->options.tsr[i].hysteresis); dptf_write_STR(config->options.tsr[i].desc); + acpigen_pop_len(); /* Scope */ } } }

-- To view, visit https://review.coreboot.org/c/coreboot/+/43458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9298c442c047c5f7f606574d900057a7c004b47f Gerrit-Change-Number: 43458 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1536

days inactive

1540

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Duncan Laurie (Code Review)
Karthik Ramasubramanian (Code Review)
Sumeet R Pawnikar (Code Review)
Tim Wawrzynczak (Code Review)