Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75746?usp=email )
Change subject: soc/intel/cmd/blk/cse: Add a kconfig option to store CSE version
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/75746/comment/b87656ea_b5185782 :
PS1, Line 48: SOC_INTEL_STORE_CSE_VERSION
nit:Feedback from community to use cache instead store...may be SOC_INTEL_CACHE_CSE_RW_FW_VERSION?
i don't think Cache is the right terminology here because the source of the cache is always assumed as temp memory but here the goal is to store inside persistent memory.
I won't ignore this Kconfig as we don't need this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75746?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8a62d00e6ed15fbe595f3729d921df8cef42fdb
Gerrit-Change-Number: 75746
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 10:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment