Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31842
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
src/mainboard/pcengines/apu2: Bring back copyrights
The copyright notices of Eltan B.V. have been removed by mistake before sending the patch with board support. Revert back to be consent with the license.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Ic5948ab60a661ef78e4e5c8571535a096fc88ea5 --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/pcengines/apu2/Makefile.inc 2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/31842/1
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 6e65a6e..8487612 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -2,7 +2,8 @@ # This file is part of the coreboot project. # # Copyright (C) 2012 Advanced Micro Devices, Inc. -# Copyright (C) 2015 Kyösti Mälkki kyosti.malkki@gmail.com +# Copyright (C) 2015 Kyösti Mälkki kyosti.malkki@gmail.com +# Copyright (C) 2016 Eltan B.V. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by diff --git a/src/mainboard/pcengines/apu2/Makefile.inc b/src/mainboard/pcengines/apu2/Makefile.inc index 0e89740..4e6364e 100644 --- a/src/mainboard/pcengines/apu2/Makefile.inc +++ b/src/mainboard/pcengines/apu2/Makefile.inc @@ -2,6 +2,7 @@ # This file is part of the coreboot project. # # Copyright (C) 2012 Advanced Micro Devices, Inc. +# Copyright (C) 2016 Eltan B.V. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 1:
https://review.coreboot.org/c/coreboot/+/14138/2..3/src/mainboard/pcengines/...
Lines from Eltan tree were dropped.
https://review.coreboot.org/c/coreboot/+/14138/3..16/src/mainboard/pcengines...
The lines were not added back until the merge, and not after?
At least fix mangling my name, but I don't see actual Eltan fingerprint on that Kconfig file, if we go digging on present lines. Whether it's derived work there when it has been reviewed along I say definetly yes. There has been some discussion about going for generic "copyright by authors".
IANAL
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 1: Code-Review-1
Same non-merged lines on Makefile, Eltan's changes are no longer present with or after patchset 3.
Hello Kyösti Mälkki, Piotr Król, Frans Hendriks, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31842
to look at the new patch set (#2).
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
src/mainboard/pcengines/apu2: Bring back copyrights
The copyright notices of Eltan B.V. have been removed by mistake before sending the patch with board support. Revert back to be consent with the license.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Ic5948ab60a661ef78e4e5c8571535a096fc88ea5 --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/pcengines/apu2/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/31842/2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 2:
Patch Set 1:
https://review.coreboot.org/c/coreboot/+/14138/2..3/src/mainboard/pcengines/...
Lines from Eltan tree were dropped.
https://review.coreboot.org/c/coreboot/+/14138/3..16/src/mainboard/pcengines...
The lines were not added back until the merge, and not after?
Not all lines I guess. According to the earliest source code I have, git blame showed that almost whole files were created/modified by Eltan. Believing it or not is a different matter. The board support was ported to recent coreboot tree based on the source code developed by Eltan.
At least fix mangling my name, but I don't see actual Eltan fingerprint on that Kconfig file, if we go digging on present lines. Whether it's derived work there when it has been reviewed along I say definetly yes. There has been some discussion about going for generic "copyright by authors".
I'm sorry, encoding crap in the editor...
IANAL
IANAL too, that is the case.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 2: Code-Review+2
Yes, I know the background of the tree. At least the SPD filenames originate from Eltan.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Yes, I know the background of the tree. At least the SPD filenames originate from Eltan.
Eltan has created the whole tree, but added copyright lines to a few files only.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
Yes, I know the background of the tree. At least the SPD filenames originate from Eltan.
Eltan has created the whole tree, but added copyright lines to a few files only.
May 26th 2016 I pushed amd/db-ft3b-lc patchset #1 May 29th 2016 Piotr pushes pcengines/apu2 patchset #3 were my copyright line appears in Kconfig
You can revisit #2 .. #3 diff for Kconfig and Makefile.inc. The only remotely copyrightable thing in these files that got merged from Eltan tree was the change of SPD data filename.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31842 )
Change subject: src/mainboard/pcengines/apu2: Bring back copyrights ......................................................................
src/mainboard/pcengines/apu2: Bring back copyrights
The copyright notices of Eltan B.V. have been removed by mistake before sending the patch with board support. Revert back to be consent with the license.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Ic5948ab60a661ef78e4e5c8571535a096fc88ea5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/31842 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/pcengines/apu2/Makefile.inc 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 6e65a6e..6c3958b 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -3,6 +3,7 @@ # # Copyright (C) 2012 Advanced Micro Devices, Inc. # Copyright (C) 2015 Kyösti Mälkki kyosti.malkki@gmail.com +# Copyright (C) 2016 Eltan B.V. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by diff --git a/src/mainboard/pcengines/apu2/Makefile.inc b/src/mainboard/pcengines/apu2/Makefile.inc index 0e89740..4e6364e 100644 --- a/src/mainboard/pcengines/apu2/Makefile.inc +++ b/src/mainboard/pcengines/apu2/Makefile.inc @@ -2,6 +2,7 @@ # This file is part of the coreboot project. # # Copyright (C) 2012 Advanced Micro Devices, Inc. +# Copyright (C) 2016 Eltan B.V. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by
-
Frans Hendriks (Code Review) -
Kyösti Mälkki (Code Review)
-
Michał Żygowski (Code Review)
-
Patrick Georgi (Code Review)