Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS ......................................................................
mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS
Drawman board has different port configuration where it has HDMI port on DDI2. We need separate VBT file for drawman to handle this since all other variants has type-C port.
Stitching vbt_drawman.bin will allow coreboot to check fw_config and get correct VBT files as per port supported.
BUG=b:161190931 BRANCH=dedede TEST=vbt_drawman is stitched into CBFS and drawcia and drawman boots fine.
Cq-Depend: chrome-internal:3436383 Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/Makefile.inc 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48205/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/Makefile.inc b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc index 24c75d1..cef8047 100644 --- a/src/mainboard/google/dedede/variants/drawcia/Makefile.inc +++ b/src/mainboard/google/dedede/variants/drawcia/Makefile.inc @@ -1,3 +1,10 @@ ## SPDX-License-Identifier: GPL-2.0-or-later
ramstage-$(CONFIG_FW_CONFIG) += variant.c + +cbfs-files-y += vbt_drawman.bin +vbt_drawman.bin-file := 3rdparty/blobs/baseboard-dedede/vbt_drawman.bin +vbt_drawman.bin-type := raw +vbt_drawman.bin-compression := lzma + +
Maulik V Vaghela has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS ......................................................................
Removed reviewer Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48205/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48205/1/src/mainboard/google/dedede... PS1, Line 6: vbt_drawman.bin-file := 3rdparty/blobs/baseboard-dedede/vbt_drawman.bin trailing whitespace
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Meera Ravindranath, Ronak Kanabar, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48205
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS ......................................................................
mb/google/dedede/var/drawcia: add vbt_drawman file to CBFS
Drawman board has different port configuration where it has HDMI port on DDI2. We need separate VBT file for drawman to handle this since all other variants has type-C port.
Stitching vbt_drawman.bin will allow coreboot to check fw_config and get correct VBT files as per port supported.
BUG=b:161190931 BRANCH=dedede TEST=vbt_drawman is stitched into CBFS and drawcia and drawman boots fine.
Cq-Depend: chrome-internal:3436383 Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/dedede/variants/drawcia/Makefile.inc 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48205/2
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Meera Ravindranath, Ronak Kanabar, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48205
to look at the new patch set (#3).
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
drivers/intel/gma: Enable option to add second VBT with custom name
Drawman board has different port configuration where it has HDMI port on DDI2. We need separate VBT file for drawman to handle this since all other variants has type-C port.
This case requires coreboot to keep 2 separate VBT files: vbt.bin and vbt_drawman.bin. coreboot should be able to select correct file after reading fw_config during run time.
To generalize this solution, this patch provides Kconfig to add custom VBT file name and also user can provide name as which VBT file will be stored in CBFS.
Example: CONFIG_INTEL_GMA_ADD_CUSTOM_VBT=y CONFIG_INTEL_GMA_CUSTOM_VBT_FILE="blobs/vbt_draw.bin" CONFIG_INTEL_GMA_CUSTOM_VBT_CBFS_NAME="vbt_drawman.bin"
Adding these 3 config will allow user to add one more vbt file "vbt_draw.bin" and it'll save file in CBFS region with name "vbt_drawman.bin"
BUG=b:161190931 BRANCH=dedede TEST=vbt_drawman is stitched into CBFS and drawcia and drawman boots fine.
Cq-Depend: chrome-internal:3436383 Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/device/Kconfig M src/drivers/intel/gma/Makefile.inc 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48205/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Patch Set 3:
Wouldn't it be easier to patch the VBT after loading it?
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Subrata Banik, Meera Ravindranath, Ronak Kanabar, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48205
to look at the new patch set (#4).
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
drivers/intel/gma: Enable option to add second VBT with custom name
Drawman board has different port configuration where it has HDMI port on DDI2. We need separate VBT file for drawman to handle this since all other variants has type-C port.
This case requires coreboot to keep 2 separate VBT files: vbt.bin and vbt_drawman.bin. coreboot should be able to select correct file after reading fw_config during run time.
To generalize this solution, this patch provides Kconfig to add custom VBT file name and also user can provide name as which VBT file will be stored in CBFS.
Example: CONFIG_INTEL_GMA_ADD_CUSTOM_VBT=y CONFIG_INTEL_GMA_CUSTOM_VBT_FILE="blobs/vbt_draw.bin" CONFIG_INTEL_GMA_CUSTOM_VBT_CBFS_NAME="vbt_drawman.bin"
Adding these 3 config will allow user to add one more vbt file "vbt_draw.bin" and it'll save file in CBFS region with name "vbt_drawman.bin"
BUG=b:161190931 BRANCH=dedede TEST=vbt_drawman is stitched into CBFS and drawcia and drawman boots fine.
Cq-Depend: chrome-internal:3436383 Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/device/Kconfig M src/drivers/intel/gma/Makefile.inc 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48205/4
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Subrata Banik, Meera Ravindranath, Ronak Kanabar, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48205
to look at the new patch set (#5).
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
drivers/intel/gma: Enable option to add second VBT with custom name
Drawman board has different port configuration where it has HDMI port on DDI2. We need separate VBT file for drawman to handle this since all other variants has type-C port.
This case requires coreboot to keep 2 separate VBT files: vbt.bin and vbt_drawman.bin. coreboot should be able to select correct file after reading fw_config during run time.
To generalize this solution, this patch provides Kconfig to add custom VBT file name and also user can provide name as which VBT file will be stored in CBFS.
Example: CONFIG_INTEL_GMA_ADD_CUSTOM_VBT=y CONFIG_INTEL_GMA_CUSTOM_VBT_FILE="blobs/vbt_draw.bin" CONFIG_INTEL_GMA_CUSTOM_VBT_CBFS_NAME="vbt_drawman.bin"
Adding these 3 config will allow user to add one more vbt file "vbt_draw.bin" and it'll save file in CBFS region with name "vbt_drawman.bin"
BUG=b:161190931 BRANCH=dedede TEST=vbt_drawman is stitched into CBFS and drawcia and drawman boots fine.
Change-Id: Ic68e211126eadbd2c866027619e1ed4e6128d905 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/device/Kconfig M src/drivers/intel/gma/Makefile.inc 2 files changed, 27 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/48205/5
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Patch Set 5:
Verified on Drawman with HDMI port:
fw_config match found: DB_PORTS=DB_PORTS_1A_HDMI FMAP: area FW_MAIN_A found @ 483000 (2172864 bytes) CBFS: Found 'vbt_drawman.bin' @0xbb500 size 0x4b6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG@26 PS5, Line 26: Adding these 3 config will allow user to add one more vbt file What happens when a 3rd VBT file is required? In general I don't think it is correct to keep adding configs for each of these VBTs. We need to basically add all required VBT files to CBFS and let mainboard decide at runtime which one it actually wants to use.
This has already been handled on previous platforms and not something new for Draw*.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48205/5//COMMIT_MSG@26 PS5, Line 26: Adding these 3 config will allow user to add one more vbt file
What happens when a 3rd VBT file is required? In general I don't think it is correct to keep adding […]
Exactly what Furquan said, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... for an example, where we choose at runtime which VBT file to load from the CBFS
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Patch Set 5: Code-Review-1
Thank you Furquan. Sorry, I was not aware of other method. I checked now and its much more cleaner. I will abandon the patch and stitch VBT file directly into CBFS.
Maulik V Vaghela has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48205 )
Change subject: drivers/intel/gma: Enable option to add second VBT with custom name ......................................................................
Abandoned
-
build bot (Jenkins) (Code Review) -
Furquan Shaikh (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Rudolph (Code Review)
-
Tim Wawrzynczak (Code Review)