Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63313 )
Change subject: soc/amd/sabrina: Build support to add SPL File ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63313/comment/4042fe80_eeb884bd PS1, Line 7: Build support to add SPL File Please make it a statement:
Add build support to add SPL file
But maybe:
Kconfig: Allow to specify custom SPL table file
https://review.coreboot.org/c/coreboot/+/63313/comment/740bee47_22efd674 PS1, Line 14: SPL file Mention the file you used?
https://review.coreboot.org/c/coreboot/+/63313/comment/33e57eee_a1a2bce1 PS1, Line 14: Boot boot
File src/soc/amd/sabrina/Kconfig:
https://review.coreboot.org/c/coreboot/+/63313/comment/7f758452_aeb8ffc1 PS1, Line 394: which is created by AMD Why can it only be created by AMD?
https://review.coreboot.org/c/coreboot/+/63313/comment/b2eaa620_aad46215 PS1, Line 394: Have a mainboard specific SPL table file, which is created by AMD Please add a line, what an SPL file is.
-
Paul Menzel (Code Review)