[S] Change in coreboot[master]: soc/intel/common/tcss: Configure USB-C ports with attached devices
Attention is currently required from: Eric Lai, John Su, John Zhao, Kapil Porwal, Matt DeVillier, Subrata Banik.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )
Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/72909/comment/2c284af7_bd276914 : PS4, Line 361: ret = send_pmc_connect_request(i, &mux_info, port_info);
I'm afraid that we might end up sending the PMC connect cmd twice if DP=1 and USB=1 for the same por […]
And that's the case here. Please take a look at logs below. ``` [DEBUG] port C0 DISC req: usage 1 usb3 1 usb2 2 [DEBUG] Raw Buffer output 0 00000211 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [DEBUG] port C1 DISC req: usage 1 usb3 3 usb2 3 [DEBUG] Raw Buffer output 0 00000331 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [DEBUG] port C2 DISC req: usage 1 usb3 2 usb2 1 [DEBUG] Raw Buffer output 0 00000121 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [INFO ] AP Mode Entry enabled, skip waiting for DisplayPort connection [INFO ] DP ready after 100 ms [INFO ] HPD ready after 705 ms [DEBUG] port C1 CONN req: usage 0 usb3 3 usb2 3 ufp 0 ori_hsl 1 ori_sbu 1 dbg_acc 0 [DEBUG] Raw Buffer output 0 00006330 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [DEBUG] port C1 SAFE req: usage 2 usb3 3 [DEBUG] Raw Buffer output 0 00000032 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [DEBUG] port C1 ALT_1 req: usage 3 usb3 3 dp_mode 1 [DEBUG] port C1 ALT_2 req: polarity 1 cable 0 ufp 0 dp_mode 4 [DEBUG] Raw Buffer output 0 00001033 [DEBUG] Raw Buffer output 1 00000402 [DEBUG] pmc_send_ipc_cmd succeeded [DEBUG] Raw Buffer output 0 00001034 [DEBUG] Raw Buffer output 1 00000000 [DEBUG] pmc_send_ipc_cmd succeeded [INFO ] Port C1 is configured to DP mode! [DEBUG] port C1 CONN req: usage 0 usb3 3 usb2 3 ufp 0 ori_hsl 1 ori_sbu 1 dbg_acc 0 [DEBUG] Raw Buffer output 0 00006330 [DEBUG] Raw Buffer output 1 00000000 [ERROR] pmc_send_ipc_cmd status: fatal [ERROR] Port 1 connect request failed ```
-
Jakub Czapiga (Code Review)