Change in coreboot[master]: herobrine: change board ID detect to tristate solution. - coreboot-gerrit

13 Oct 2021


      Attention is currently required from: Ravi kumar.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58042 )
Change subject: herobrine: change board ID detect to tristate solution.
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/58042/comment/f0b65382_165a3daf 
PS3, Line 20: gpio_binary_first_base3_value
No, this should be gpio_base3_value per https://issuetracker.google.com/193807794
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58042
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33245605f8d0f427ad643e9a3d5328ebb79d1c23
Gerrit-Change-Number: 58042
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Comment-Date: Wed, 13 Oct 2021 01:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment