Change in coreboot[master]: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support
Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43551 )
Change subject: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support ......................................................................
mb/google/dedede/var/drawcia: Add G2Touch touchscreen support
BUG=b:155002684 TEST=build drawcia, and check touchscreen can work
Change-Id: I29a891e07bb3c1d8ebe17666c18bfcf3bc1c361d Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/43551/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index bc10e1f..78fec88 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -74,6 +74,20 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # I2C 2 device pci 19.0 on chip drivers/i2c/generic
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43551 )
Change subject: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support ......................................................................
Patch Set 1:
This change is ready for review.
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43551 )
Change subject: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43551 )
Change subject: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43551 )
Change subject: mb/google/dedede/var/drawcia: Add G2Touch touchscreen support ......................................................................
mb/google/dedede/var/drawcia: Add G2Touch touchscreen support
BUG=b:155002684 TEST=build drawcia, and check touchscreen can work
Change-Id: I29a891e07bb3c1d8ebe17666c18bfcf3bc1c361d Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43551 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index bc10e1f..78fec88 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -74,6 +74,20 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7503"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # I2C 2 device pci 19.0 on chip drivers/i2c/generic
-
Chen Wisley (Code Review) -
Justin TerAvest (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)