Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Arthur Heymans. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Arthur Heymans, Nick Vaccaro, Eric Lai, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63518
to look at the new patch set (#9).
Change subject: soc/intel/common/sa: Add `finalize` operation for systemagent ......................................................................
soc/intel/common/sa: Add `finalize` operation for systemagent
The system agent `.final` operation ensures locking the PAM register hence, skip dedicated calling into `sa_lock_pam()` from the SoC `finalize.c` file. Dropped sa_lock_pam() call from ADL/CNL/EHL/JSL and TGL.
Also, convert `sa_lock_pam` function into a static function.
BUG=b:211954778 TEST=Able to build google/brya with these changes and coreboot log with this code change as below:
[INFO ] Finalize devices... [DEBUG] PCI: 00:00.0 final
localhost ~ # lspci -xxx | less
00:00.0 Host bridge: Device 8086:4601 (rev 04)
Bit 0 for all PAM registers a.k.a, PAMx_0_0_0_PCI.LOCK bit is set (meaning locked).
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ibd464d2507393ed0c746eb1fbd10e36092ed5599 --- M src/soc/intel/alderlake/finalize.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/common/block/include/intelblocks/systemagent.h M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/elkhartlake/finalize.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/tigerlake/finalize.c 7 files changed, 17 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/63518/9