HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38311 )
Change subject: arch/x86/cf9_reset: Fix typo ......................................................................
arch/x86/cf9_reset: Fix typo
Change-Id: I4a8d29ab647837965e5341d019664f0ed401639a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/cf9_reset.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38311/1
diff --git a/src/arch/x86/cf9_reset.c b/src/arch/x86/cf9_reset.c index ccfaa7d..d93bed7 100644 --- a/src/arch/x86/cf9_reset.c +++ b/src/arch/x86/cf9_reset.c @@ -35,7 +35,7 @@ * A full reset in terms of the CF9 register triggers a power cycle * (i.e. S0 -> S5 -> S0 transition). Thus, it could be called a * "cold reset". - * Note: Not all x86 implementations comply with this defitinion, + * Note: Not all x86 implementations comply with this definition, * some may require additional configuration to power cycle. */ void do_full_reset(void)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38311 )
Change subject: arch/x86/cf9_reset: Fix typo ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38311 )
Change subject: arch/x86/cf9_reset: Fix typo ......................................................................
arch/x86/cf9_reset: Fix typo
Change-Id: I4a8d29ab647837965e5341d019664f0ed401639a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38311 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/cf9_reset.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/arch/x86/cf9_reset.c b/src/arch/x86/cf9_reset.c index ccfaa7d..d93bed7 100644 --- a/src/arch/x86/cf9_reset.c +++ b/src/arch/x86/cf9_reset.c @@ -35,7 +35,7 @@ * A full reset in terms of the CF9 register triggers a power cycle * (i.e. S0 -> S5 -> S0 transition). Thus, it could be called a * "cold reset". - * Note: Not all x86 implementations comply with this defitinion, + * Note: Not all x86 implementations comply with this definition, * some may require additional configuration to power cycle. */ void do_full_reset(void)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)