Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/81849?usp=email )
Change subject: soc/intel: Add Panther Lake PCIE device IDs ......................................................................
Patch Set 15:
(1 comment)
Patchset:
PS15:
Hi Subrata, it seems you missed to review the CL before it got merged,
I was waiting to review the once I have access to the doc and I'm doing the review now because I got access to all PTL doc this week early. IMO, the cl landed in rush w/o following the review in proper. For example: we landed LNL DID2 in form of PTL DID2 (details https://review.coreboot.org/c/coreboot/+/83491/1/src/include/device/pci_ids....). Hence, added this section to share my official feedback.
since during the review, it was asked to remove the SKU Type due to program being in early stage(PSS) and some NDA terms. Following the review comments, SKU Type has been removed,
I don't know which SKU type you are referring here. Atleast I'm only interested to land the SKU IDs that CrOS will build for PTL (and rest can be assumed upsteam late by community)
though it is planned to update and add SKU U & H info post apporval. Thanks for taking up and pushing the changes required CLs "fatcat_ptl_pci_ids".
I'm not aware of any approval process to be honest here. I got the doc and found that the DIDs are not aligned with our SOC roadmap for PTL hence, I have started by myself knowing you folks have more important work at this stage.