Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39264 )
Change subject: soc/intel/common/block: tco: enable intruder SMI ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39264/6/src/soc/intel/common/block/... File src/soc/intel/common/block/smbus/tco.c:
https://review.coreboot.org/c/coreboot/+/39264/6/src/soc/intel/common/block/... PS6, Line 155: tco_intruder_smi_enable(); Shouldn't this be based on the Kconfig option as well? If feels a little weird to enable it here, but not the global control. I think both should be controlled by Kconfig option.