Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83393?usp=email )
Change subject: soc/intel/cmn/cse: Refactor CBMEM ID handling for flexibility
......................................................................
Patch Set 2:
(1 comment)
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/83393/comment/38beba20_d2165708?usp... :
PS2, Line 265: #if CONFIG(SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD)
Why would you check for a coreboot Kconfig option in libpayload? I am puzzled that it even compiles. I would assume it is enough to check for the CBMEM_ID's since they are not existing if the option hasn't been supplied during the coreboot build.
hmm, valid point. let me drop the CPP
CB:83436 , please help to review the code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83393?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I74f70959715f9fd6d4d298faf310592874cc35d4
Gerrit-Change-Number: 83393
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Fri, 12 Jul 2024 17:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com