Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Prashant Malani, Nick Vaccaro, Benson Leung.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59401 )
Change subject: ec/google/chromeec: Add PLD to EC conn in ACPI table
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59401/comment/d5765dee_14b364a8
PS1, Line 8:
Add a commit message providing a bit more detail about what's being done in this CL.
Added more information. Thank you for review!
https://review.coreboot.org/c/coreboot/+/59401/comment/610e46de_360756e6
PS1, Line 10: TEST=emerge-brya coreboot
I believe you also tested this on a brya by dumping the SSDT and verifying the PLD object is written […]
Yes, added it too. Thank you for review!
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/59401/comment/739d89c1_57f62598
PS1, Line 125: struct drivers_usb_acpi_config *config;
:
: config = NULL;
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/59401/comment/abe323e8_d0c950cc
PS1, Line 152: struct acpi_pld pld;
Probably should be 0-initialized.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc56ecd4e8954ffaace3acd9528a064b5fa2cf6f
Gerrit-Change-Number: 59401
Gerrit-PatchSet: 2
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Benson Leung
bleung@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Benson Leung
bleung@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 18:14:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment