Change in coreboot[master]: sb/lynxpoint: Use macros instead of hard-coded IDs - coreboot-gerrit

10 Nov 2019


      Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36706 )
Change subject: sb/lynxpoint: Use macros instead of hard-coded IDs
......................................................................
Patch Set 2:
...
Patch Set 2:
`cmp` indicates that the resulting binary is different. Not sure why, checked the IDs multiple times. Maybe because of I added new IDs to pci_ids.h?
That's a bit worrisome. maybe you can track which file changed by comparing the .o files in build/ ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36706
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d0f7122e461b78526692b78f79edcafafd3286
Gerrit-Change-Number: 36706
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 10 Nov 2019 18:39:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment