[L] Change in coreboot[main]: Add support for MiTAC Computing Whitestone-2 mainboard

[Mark Chang (Code Review)]

Attention is currently required from: Angel Pons, Angel Pons, Arthur Heymans, Christian Walter, Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, [e-mail].

Mark Chang has posted comments on this change by Mark Chang. ( https://review.coreboot.org/c/coreboot/+/85532?usp=email )

Change subject: Add support for MiTAC Computing Whitestone-2 mainboard
......................................................................

Patch Set 1:

(15 comments)

Patchset:

PS1: 
Done

Commit Message:

https://review.coreboot.org/c/coreboot/+/85532/comment/6030a655_1a626e6b?usp... :
PS1, Line 8:
> Could you please add a body to the commit message? I would suggest describing the board (looks like  […]

Done

File configs/config.mitaccomputing_ws_2:

PS1:
> I see references to site-local here. […]

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/7aed971b_66f03b1a?usp... :
PS1, Line 15: CONFIG_X2APIC_LATE_WORKAROUND=y
> We only verified Intel 5433N on our Whitestone-2.

Done

File src/mainboard/mitaccomputing/whitestone-2/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/85532/comment/b9c5812e_17b40d03?usp... :
PS1, Line 4: #include <soc/intel/common/acpi/acpi_wake_source.asl>
> Will remove it.

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/0dc71faa_69780f1b?usp... :
PS1, Line 13: }
> Add "#include <arch/x86/acpi/post.asl> will trigger build error.

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/0b3963a9_10c79976?usp... :
PS1, Line 30:
> We will remove it.

Done

File src/mainboard/mitaccomputing/whitestone-2/board_info.txt:

PS1:
> Update ROM package: SOIC-16

Done

File src/mainboard/mitaccomputing/whitestone-2/bootblock.c:

https://review.coreboot.org/c/coreboot/+/85532/comment/56525091_3609d9e1?usp... :
PS1, Line 18: static void enable_espi_lpc_io_windows(void)
> We could use below APIs to update it. […]

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/a6cc5493_58dfc7db?usp... :
PS1, Line 23: 	 * For that end it is wired into BMC virtual port.
> The Whitestone-2 only use SUART1. […]

Done

File src/mainboard/mitaccomputing/whitestone-2/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/85532/comment/109db048_a96b6272?usp... :
PS1, Line 10: 	0x20110725	// OEM revision
> Remove it

Done

File src/mainboard/mitaccomputing/whitestone-2/mainboard.c:

https://review.coreboot.org/c/coreboot/+/85532/comment/0757fa01_ea724e1b?usp... :
PS1, Line 46: }
> These E810 devices are Ethernet NICs. […]

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/aabc2f92_1971a347?usp... :
PS1, Line 71: }
> Will this duplicate with smbios_generate_type41_from_devtree?

Done

https://review.coreboot.org/c/coreboot/+/85532/comment/d512eef5_dadf05bf?usp... :
PS1, Line 80: };
> Angel, you're right, it's invoked automatically.

Done

File src/mainboard/mitaccomputing/whitestone-2/romstage.c:

https://review.coreboot.org/c/coreboot/+/85532/comment/da7d0696_e3a68e0e?usp... :
PS1, Line 18: Protocl
> resolved

Done