Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30287 )
Change subject: soc/intel/common: Add Kconfig option to choose desired MP Init for platform
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon...
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon...
PS10, Line 58: help
If this is to be user selectable, you need to add a title to this so it shows up in menuconfig etc. […]
Done
https://review.coreboot.org/#/c/30287/10/src/soc/intel/common/block/cpu/Kcon...
PS10, Line 68: USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
that's quite a mouthful and I still don't know what it's supposed to do: install the PPI if this fla […]
yes Patrick.
Do you think help string is not enough to understand this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbea463fdaf97d68c21a759c37f49492d58a056b
Gerrit-Change-Number: 30287
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 22 Mar 2019 06:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment