[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock

[Ashish Kumar Mishra (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Kapil Porwal, Saurabh Mishra, Tarun.

Ashish Kumar Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
......................................................................

Patch Set 14:

(8 comments)

File src/soc/intel/pantherlake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/83354/comment/65123cec_e21e4eb8?usp... :
PS14, Line 10:  */
Please add a new line here.

File src/soc/intel/pantherlake/include/soc/pci_devs.h:

https://review.coreboot.org/c/coreboot/+/83354/comment/58961eac_a903f3cd?usp... :
PS14, Line 9: #if !defined(__SIMPLE_DEVICE__)
Suggestion:
Please align this #if flow with #if in line 19 below.
i.e. use #if defined() in both, instead of mixing.
Easier to read.

https://review.coreboot.org/c/coreboot/+/83354/comment/73e9888c_1e9e23ae?usp... :
PS14, Line 165: #define PCI_DEVFN_PCIE7		_PCI_DEVFN(PCIE_1, 6)
Please fix spaces.

https://review.coreboot.org/c/coreboot/+/83354/comment/46fb5f56_d9596c0d?usp... :
PS14, Line 211: #endif
Suggestion: For such nested endif, please add a comment for which #if, for better readability.

https://review.coreboot.org/c/coreboot/+/83354/comment/c8e2b804_54b493e1?usp... :
PS14, Line 219: #endif
Same as line 211 above.

File src/soc/intel/pantherlake/include/soc/pcr_ids.h:

https://review.coreboot.org/c/coreboot/+/83354/comment/7d3ca966_c303459a?usp... :
PS14, Line 6: /*
            :  * Port ids
            : */
> why multiline ?

These multiline comments at file header follows is seen in earlier soc files as well, but if we use single line comments we scroll fewer 2 lines.

File src/soc/intel/pantherlake/include/soc/pm.h:

https://review.coreboot.org/c/coreboot/+/83354/comment/173884c3_a37c467e?usp... :
PS14, Line 80: #define GPE_STS_RSVD            GPE_STD
Do we need duplicating macros?

https://review.coreboot.org/c/coreboot/+/83354/comment/bc96212d_a0d207f3?usp... :
PS14, Line 97: #define   PME_B0_EN_BIT		13
If this macro is unused anywhere else, we could remove this and follow same (1 << x) as earlier lines. If required, we can add a comment.