Change in coreboot[master]: mb/google/brya/var/brask: Configure the ISOLATE pin of LAN - coreboot-gerrit

9 Dec 2021


      Attention is currently required from: David Wu, Hou-hsun Lee, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configure the ISOLATE pin of LAN
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/78fcc9c1_38a5ad16 
PS5, Line 86: 				register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
...
GPP_A7 should be the LAN_WAKE_ODL pin according to https://partnerissuetracker.corp.google. […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e82dbc1e6c68cbd84b603adc7fdc3ee1d4d3392
Gerrit-Change-Number: 58105
Gerrit-PatchSet: 9
Gerrit-Owner: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hou-hsun Lee hou-hsun.lee@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Hou-hsun Lee hou-hsun.lee@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 21:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hou-hsun Lee hou-hsun.lee@intel.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee zhuohao@google.com
Comment-In-Reply-To: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment