Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Rob Barnes, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52745 )
Change subject: device/dram: Add support for LPDDR4 4266
......................................................................
Patch Set 2:
(2 comments)
File src/device/dram/ddr4.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118036):
https://review.coreboot.org/c/coreboot/+/52745/comment/a3a9b175_658a46b0
PS2, Line 175: sizeof(ddr4_speeds)/sizeof(ddr4_speeds[0]));
Prefer ARRAY_SIZE(ddr4_speeds)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118036):
https://review.coreboot.org/c/coreboot/+/52745/comment/6b8d32e8_def04399
PS2, Line 181: sizeof(lpddr4_speeds)/sizeof(lpddr4_speeds[0]));
Prefer ARRAY_SIZE(lpddr4_speeds)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8ddfc98fff4255670c50e1ddd4d0a1326265772
Gerrit-Change-Number: 52745
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 29 Apr 2021 00:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment