Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 )
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/oryp...
File src/mainboard/system76/oryp5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/oryp...
PS3, Line 87: subsystemid 0x1558 0x95e6 inherit
This is not working as I expected: Subsystem is defaulting to 8086:7270 for most PCIe entries despite this being set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47892
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae6e530dcd52df3642cdfe74b65bfff5aa0dd402
Gerrit-Change-Number: 47892
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 24 Nov 2020 23:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment