Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ......................................................................
Patch Set 4:
(19 comments)
File src/soc/mediatek/mt8186/include/soc/dramc_soc.h:
https://review.coreboot.org/c/coreboot/+/60318/comment/81387496_3f04710f PS2, Line 7: CHANNEL_A = 0,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/cd598631_b1aba3c1 PS2, Line 8: CHANNEL_B,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/10889dbc_bd92d8cb PS2, Line 9: CHANNEL_MAX,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/d98da4bb_bfb1408e PS2, Line 13: RANK_0 = 0,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/0d3fab92_d147d9cb PS2, Line 14: RANK_1,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/e33c1ad7_c210743e PS2, Line 15: RANK_MAX,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/b826c30b_f43234f2 PS2, Line 20: DRAM_DFS_SHUFFLE_1 = 0,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/19a9d66d_a9364af1 PS2, Line 21: DRAM_DFS_SHUFFLE_2,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/4ede738d_761c9c63 PS2, Line 22: DRAM_DFS_SHUFFLE_3,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/1d5a737e_80f684c6 PS2, Line 23: DRAM_DFS_SHUFFLE_4,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/812eb0cb_d37fce34 PS2, Line 24: DRAM_DFS_SHUFFLE_5,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/5fd02559_2cb569fe PS2, Line 25: DRAM_DFS_SHUFFLE_6,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/56887494_a892b88a PS2, Line 26: DRAM_DFS_SHUFFLE_7,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/ec293511_128a8e53 PS2, Line 27: DRAM_DFS_SHUFFLE_8,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/8567092c_626434d2 PS2, Line 28: DRAM_DFS_SHUFFLE_9,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/a7ce3133_4734306c PS2, Line 29: DRAM_DFS_SHUFFLE_10,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/8323100f_82f5459c PS2, Line 30: DRAM_DFS_SHUFFLE_MAX,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/dee67d4b_6c451620 PS2, Line 41: CBT_NORMAL_MODE = 0,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60318/comment/6c91247d_18f8855d PS2, Line 42: CBT_BYTE_MODE1,
please, no spaces at the start of a line
Please fix.
-
Rex-BC Chen (Code Review)