Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44844 )
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
util/spd_tools: Remove intel subfolder
Move ddr4 and lp4x to spd_tools root folder. The tool now applies to non intel platforms.
BUG=b:162939176 TEST=Run tool
Signed-off-by: Rob Barnes robbarnes@google.com Change-Id: I0941ea036d760ee27eb34f259f4506a4b7584bee --- R util/spd_tools/ddr4/README.md R util/spd_tools/ddr4/gen_part_id.go R util/spd_tools/ddr4/gen_spd.go R util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt R util/spd_tools/lp4x/README.md R util/spd_tools/lp4x/gen_part_id.go R util/spd_tools/lp4x/gen_spd.go R util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt 8 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/44844/1
diff --git a/util/spd_tools/intel/ddr4/README.md b/util/spd_tools/ddr4/README.md similarity index 100% rename from util/spd_tools/intel/ddr4/README.md rename to util/spd_tools/ddr4/README.md diff --git a/util/spd_tools/intel/ddr4/gen_part_id.go b/util/spd_tools/ddr4/gen_part_id.go similarity index 100% rename from util/spd_tools/intel/ddr4/gen_part_id.go rename to util/spd_tools/ddr4/gen_part_id.go diff --git a/util/spd_tools/intel/ddr4/gen_spd.go b/util/spd_tools/ddr4/gen_spd.go similarity index 100% rename from util/spd_tools/intel/ddr4/gen_spd.go rename to util/spd_tools/ddr4/gen_spd.go diff --git a/util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt b/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt similarity index 100% rename from util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt rename to util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt diff --git a/util/spd_tools/intel/lp4x/README.md b/util/spd_tools/lp4x/README.md similarity index 100% rename from util/spd_tools/intel/lp4x/README.md rename to util/spd_tools/lp4x/README.md diff --git a/util/spd_tools/intel/lp4x/gen_part_id.go b/util/spd_tools/lp4x/gen_part_id.go similarity index 100% rename from util/spd_tools/intel/lp4x/gen_part_id.go rename to util/spd_tools/lp4x/gen_part_id.go diff --git a/util/spd_tools/intel/lp4x/gen_spd.go b/util/spd_tools/lp4x/gen_spd.go similarity index 100% rename from util/spd_tools/intel/lp4x/gen_spd.go rename to util/spd_tools/lp4x/gen_spd.go diff --git a/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt b/util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt similarity index 100% rename from util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt rename to util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44844 )
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
Patch Set 1: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44844 )
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44844
to look at the new patch set (#3).
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
util/spd_tools: Remove intel subfolder
Move ddr4 and lp4x to spd_tools root folder. The tool now applies to non intel platforms.
BUG=b:162939176 TEST=Run tool
Signed-off-by: Rob Barnes robbarnes@google.com Change-Id: I0941ea036d760ee27eb34f259f4506a4b7584bee --- R util/spd_tools/ddr4/README.md R util/spd_tools/ddr4/gen_part_id.go R util/spd_tools/ddr4/gen_spd.go R util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt R util/spd_tools/lp4x/README.md R util/spd_tools/lp4x/gen_part_id.go R util/spd_tools/lp4x/gen_spd.go R util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt 8 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/44844/3
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44844 )
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
util/spd_tools: Remove intel subfolder
Move ddr4 and lp4x to spd_tools root folder. The tool now applies to non intel platforms.
BUG=b:162939176 TEST=Run tool
Signed-off-by: Rob Barnes robbarnes@google.com Change-Id: I0941ea036d760ee27eb34f259f4506a4b7584bee Reviewed-on: https://review.coreboot.org/c/coreboot/+/44844 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- R util/spd_tools/ddr4/README.md R util/spd_tools/ddr4/gen_part_id.go R util/spd_tools/ddr4/gen_spd.go R util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt R util/spd_tools/lp4x/README.md R util/spd_tools/lp4x/gen_part_id.go R util/spd_tools/lp4x/gen_spd.go R util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt 8 files changed, 0 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, approved
diff --git a/util/spd_tools/intel/ddr4/README.md b/util/spd_tools/ddr4/README.md similarity index 100% rename from util/spd_tools/intel/ddr4/README.md rename to util/spd_tools/ddr4/README.md diff --git a/util/spd_tools/intel/ddr4/gen_part_id.go b/util/spd_tools/ddr4/gen_part_id.go similarity index 100% rename from util/spd_tools/intel/ddr4/gen_part_id.go rename to util/spd_tools/ddr4/gen_part_id.go diff --git a/util/spd_tools/intel/ddr4/gen_spd.go b/util/spd_tools/ddr4/gen_spd.go similarity index 100% rename from util/spd_tools/intel/ddr4/gen_spd.go rename to util/spd_tools/ddr4/gen_spd.go diff --git a/util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt b/util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt similarity index 100% rename from util/spd_tools/intel/ddr4/global_ddr4_mem_parts.json.txt rename to util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt diff --git a/util/spd_tools/intel/lp4x/README.md b/util/spd_tools/lp4x/README.md similarity index 100% rename from util/spd_tools/intel/lp4x/README.md rename to util/spd_tools/lp4x/README.md diff --git a/util/spd_tools/intel/lp4x/gen_part_id.go b/util/spd_tools/lp4x/gen_part_id.go similarity index 100% rename from util/spd_tools/intel/lp4x/gen_part_id.go rename to util/spd_tools/lp4x/gen_part_id.go diff --git a/util/spd_tools/intel/lp4x/gen_spd.go b/util/spd_tools/lp4x/gen_spd.go similarity index 100% rename from util/spd_tools/intel/lp4x/gen_spd.go rename to util/spd_tools/lp4x/gen_spd.go diff --git a/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt b/util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt similarity index 100% rename from util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt rename to util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44844 )
Change subject: util/spd_tools: Remove intel subfolder ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16840 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16839 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16838 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16837 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16836 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16842 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16841
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Rob Barnes (Code Review)