Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73186 )
Change subject: nb/amd/pi/00730F01/acpi_tables: use existing IO_APIC2_ADDR definition ......................................................................
nb/amd/pi/00730F01/acpi_tables: use existing IO_APIC2_ADDR definition
Use the existing IO_APIC2_ADDR definition instead of a magic value.
TEST=Timeless build results in identical image for pcengines/apu2
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I7ee039e23309fdae0d614bb1fb0610d82564bf3b --- M src/northbridge/amd/pi/00730F01/acpi_tables.c 1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/73186/1
diff --git a/src/northbridge/amd/pi/00730F01/acpi_tables.c b/src/northbridge/amd/pi/00730F01/acpi_tables.c index 4febfaf..d786215 100644 --- a/src/northbridge/amd/pi/00730F01/acpi_tables.c +++ b/src/northbridge/amd/pi/00730F01/acpi_tables.c @@ -2,6 +2,7 @@
#include <acpi/acpi.h> #include <arch/ioapic.h> +#include <northbridge/amd/nb_common.h>
unsigned long acpi_fill_madt(unsigned long current) { @@ -14,7 +15,7 @@
/* TODO: Remove the hardcode */ current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current, CONFIG_MAX_CPUS + 1, - 0xFEC20000, 24); + IO_APIC2_ADDR, 24);
current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) current, 0, 0, 2, 0);