Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64054 )
Change subject: [WIP,UNTESTED] soc/amd/common/include/espi: add more decode ranges
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/64054/comment/99856408_245a94ae
PS1, Line 17: #define ESPI_GENERIC_IO_WIN_LOW_COUNT 4
: #define ESPI_GENERIC_IO_WIN_EXT_COUNT (3 * 4)
i wonder if i really need those or if i should just provide the number of ranges by the ifdef below […]
Done
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/64054/comment/9c20773f_9d783f4e
PS1, Line 77: ESPI_DECODE_MMIO_RANGE_EN
ESPI_DECODE_MMIO_RANGE_EXT_EN
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib761cdf201c35805d68cf5e8e462607ffd9fa017
Gerrit-Change-Number: 64054
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 04 May 2022 19:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment