Attention is currently required from: Hung-Te Lin, Kiwi Liu, Mengqi Zhang, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
Change subject: soc/mediatek/common: Reduce eMMC clock frequency to 400 kHz
......................................................................
Patch Set 12: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/cb769998_d22a5aec?usp... :
PS12, Line 14: measure eMMC clock ok
please also measure the boot time.
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/84298/comment/b4ef30b6_156bddb0?usp... :
PS9, Line 432: host->src_hz = 400 * 1000 * 1000;
When we need to set a clock output frequency, we actually set a frequency division value. […]
Do you mean `50 * 1000 * 1000` is a wrong reference value because the actual source clock is running at `400MHz`?
So we should set `host->src_hz` to `400 * 1000 * 1000` in order to compute correct devision number ?
File src/soc/mediatek/common/msdc.c:
https://review.coreboot.org/c/coreboot/+/84298/comment/328be697_963955ae?usp... :
PS12, Line 353: msdc_debug("sclk: %d\n", sclk);
can you attach this log to the commit message ? (before and after the patch)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 12
Gerrit-Owner: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Gerrit-Attention: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 13:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Kiwi Liu
kiwi.liu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Mengqi Zhang
mengqi.zhang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com