Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/mt8186/devapc.c:
https://review.coreboot.org/c/coreboot/+/60317/comment/f5ca177d_a07e8fc1 PS2, Line 23: DAPC_INFRA_AO_SYS0_ATTR("INFRA_AO_SLEEP_CONTROLER",
'CONTROLER' may be misspelled - perhaps 'CONTROLLER'?
Please fix.
File src/soc/mediatek/mt8186/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/60317/comment/84f95bc5_6d187214 PS2, Line 123: DEFINE_BIT(SCP_SSPM_SEC,21)
space required after that ',' (ctx:VxV)
Please fix.