Attention is currently required from: David Milosevic, Maximilian Brune, Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76004?usp=email )
Change subject: mb/qemu-aarch64: Move probing dram to read_resources
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/emulation/qemu-aarch64/mainboard.c:
https://review.coreboot.org/c/coreboot/+/76004/comment/cb7f4c44_ea04ef62 :
PS1, Line 47: ram_resource_kb(dev, index++, (uintptr_t)_dram / KiB, ram_size_mb * KiB);
Could update this to not do the KiB dance, while we are at it.
Done. Added a bonus of not probing DRAM twice on top :-D.
Memory layout reported at the end of boot is the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76004?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaee41aec7806287ef1881372ec8ec47a4cd57d9
Gerrit-Change-Number: 76004
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Fri, 23 Jun 2023 14:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment