Attention is currently required from: Bao Zheng, Zheng Bao.
Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84131?usp=email )
Change subject: amdfwtool: Add a unified function to add combo entries ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84131/comment/c666eda5_b7f7eaaf?usp... : PS3, Line 1478: /* 0 -Compare PSP ID, 1 -Compare chip family ID */ i assume that this one is related to the id_sel element two lines below, so it would be good to move this one line down so that it is right above the corresponding line. right now i was wondering how that relates to the assert_fw_entry line and found it a bit confusing