Change in coreboot[master]: arch/x86/smbios.c: Use macro for 'type_detail'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43589 )

Change subject: arch/x86/smbios.c: Use macro for 'type_detail'
......................................................................

arch/x86/smbios.c: Use macro for 'type_detail'

Change-Id: I95c40acb2fb390c50c8d1af9dd44999f9d57c2d5
Signed-off-by: Elyes HAOUAS 
---
M src/arch/x86/smbios.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/43589/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 3c5799b..1c7f2ac 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -360,7 +360,7 @@
    t->maximum_voltage = dimm->vdd_voltage;

/* Synchronous = 1 */
-	t->type_detail = 0x0080;
+	t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS;
    /* no handle for error information */
    t->memory_error_information_handle = 0xFFFE;
    t->attributes = dimm->rank_per_dimm;

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43589 )

Change subject: arch/x86/smbios.c: Use macro for 'type_detail'
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43589 )

Change subject: arch/x86/smbios.c: Use macro for 'type_detail'
......................................................................

arch/x86/smbios.c: Use macro for 'type_detail'

Change-Id: I95c40acb2fb390c50c8d1af9dd44999f9d57c2d5
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43589
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/arch/x86/smbios.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 3c5799b..1c7f2ac 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -360,7 +360,7 @@
    t->maximum_voltage = dimm->vdd_voltage;

/* Synchronous = 1 */
-	t->type_detail = 0x0080;
+	t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS;
    /* no handle for error information */
    t->memory_error_information_handle = 0xFFFE;
    t->attributes = dimm->rank_per_dimm;