Change in coreboot[master]: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios

[Varshit B Pandya (Code Review)]

Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios

Add WWAN gpios to early gpios, which will be helpful for modules taking more
time to initialize from reset.

Change-Id: I2f8a3df5fff83c18a2e00a2fa17de058a86a2adc
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35908/1

diff --git a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
index ec8f58b..5919d40 100644
--- a/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
+++ b/src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
@@ -592,8 +592,12 @@

/* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {
-
-
+	/* F1  : CNV_GNSS_FAT */
+	PAD_CFG_TERM_GPO(GPP_F1, 1, UP_20K, DEEP),
+	/* D13 : ISH_UART0_RXD_SML0BDATA */
+	PAD_CFG_GPO(GPP_D13, 1, DEEP),
+	/* B13: WWAN_PERST_N */
+	PAD_CFG_GPO(GPP_B13, 1, PLTRST),
 };

const struct pad_config *__weak variant_gpio_table(size_t *num)

[Varshit B Pandya (Code Review)]

Hello Subrata Banik, Balaji Manigandan, Patrick Rudolph, Maulik V Vaghela, Rizwan Qureshi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35908

to look at the new patch set (#2).

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios

Add WWAN gpios to early gpios, which will be helpful for modules taking more
time to initialize from reset.

Change-Id: I2f8a3df5fff83c18a2e00a2fa17de058a86a2adc
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
1 file changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35908/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35908/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35908/1//COMMIT_MSG@9 
PS1, Line 9: Add WWAN gpios to early gpios, which will be helpful for modules taking more
Taken from schematics?

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35908/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35908/1//COMMIT_MSG@9 
PS1, Line 9: Add WWAN gpios to early gpios, which will be helpful for modules taking more
> Taken from schematics?

yes, it has been taken from board schematics

[Varshit B Pandya (Code Review)]

Hello Subrata Banik, Balaji Manigandan, Patrick Rudolph, Maulik V Vaghela, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35908

to look at the new patch set (#3).

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios

Add WWAN gpios (as per board schematics) to early gpios, which will be helpful for modules taking more
time to initialize from reset.

Change-Id: I2f8a3df5fff83c18a2e00a2fa17de058a86a2adc
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
1 file changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35908/3

[Varshit B Pandya (Code Review)]

Hello Subrata Banik, Balaji Manigandan, Patrick Rudolph, Maulik V Vaghela, Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35908

to look at the new patch set (#4).

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios

Add WWAN gpios (as per board schematics) to early gpios, which will be helpful for modules
taking more time to initialize from reset.

Change-Id: I2f8a3df5fff83c18a2e00a2fa17de058a86a2adc
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
1 file changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35908/4

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

Patch Set 4: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35908/4/src/mainboard/intel/coffeel... 
File src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/35908/4/src/mainboard/intel/coffeel... 
PS4, Line 594: early_gpio_table
Any reason why this is not handled by providing a strong implementation of variant_gpio_table() in whl_u and cml_u variant?

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35908 )

Change subject: mb/intel/coffeelake_rvp: Add WWAN related gpios to early gpios
......................................................................

Patch Set 4:
> Patch Set 4:
>
> (1 comment)

we did not have this implementation in coffeelake mainboard.
We're working on it to cleanup and have strong functions in variants.
I'll push this change on top of that