Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 adc init
......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/common/mt6685.c:
https://review.coreboot.org/c/coreboot/+/85734/comment/c185d821_0fc31142?usp... :
PS5, Line 38:
Please also add mt6685_{read/write}8. RTC needs both APIs.
https://review.coreboot.org/c/coreboot/+/85734/comment/f7324268_f51c4676?usp... :
PS5, Line 39: mt6685_get_reg_value16
mt6685_read16
https://review.coreboot.org/c/coreboot/+/85734/comment/0db1cedf_4ffa9cbb?usp... :
PS5, Line 48: mt6685_set_reg_value16
mt6685_write16
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85734?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e
Gerrit-Change-Number: 85734
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 25 Dec 2024 03:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No