Attention is currently required from: Shuo Liu.
Arthur Heymans has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84323?usp=email )
Change subject: configs/builder: Enable SHADOW_ROM_TABLE_TO_EBDA for intel CRBs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Maybe create a Kconfig parameter "SUPPORT_SIMICS SIMULATION" that selects all these right options to avoid that RO segment without making those visible in the prompt? default y seems appropriate
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84323?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I216204987ad646a5d1655323d2725cfd3415a2d7
Gerrit-Change-Number: 84323
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 10:50:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No