Attention is currently required from: Eren Peng, Ivan Chen, Nick Vaccaro, Shelley Chen.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81833/comment/a43a303a_2f19ae6d :
PS2, Line 3:
Remove extra tab.
Same for below 2 lines as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 2
Gerrit-Owner: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
hsueh.rasheed@inventec.corp-partner.google.com
Gerrit-CC: Steven Yeh
yeh.stevenct@inventec.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Fri, 12 Apr 2024 06:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment